Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #288

Merged
merged 9 commits into from
Nov 3, 2024
Merged

CI improvements #288

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3cbeb3d
ci: enforce engines more
lishaduck Oct 31, 2024
4d90fd8
chore: add devEngines
lishaduck Oct 31, 2024
154aa81
chore: add sha to packageManager
lishaduck Oct 31, 2024
996df75
ci: remove double push/pr ci runs
lishaduck Sep 23, 2024
e07cf10
ci: improve checkout
lishaduck Oct 31, 2024
a83c739
ci: add restore-keys
lishaduck Oct 31, 2024
93d45c7
ci(deps): bump actions
lishaduck Oct 31, 2024
e37ffa6
Revert "chore: add devEngines"
lishaduck Nov 3, 2024
b52cd29
ci: disable schedule
lishaduck Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ jobs:
set-safe-directory: true

- name: Setup Node.js environment
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe dependabot is not updating them because of the hash? Or because of the comment. Not sure either 🤷‍♂️

Copy link
Contributor Author

@lishaduck lishaduck Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependabot is smart enough for it to work on my other projects. If the comment is wrong, it'll also override it (rather than ignoring it or not updating), which is nice.

(Otherwise, I wouldn't use this. I prefer security updates+possible supply chain attack over old versions)

with:
node-version: 16.x
cache: 'npm'

- name: Cache ~/.elm
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
uses: actions/cache@6849a6489940f00c2f30c0fb92c6274307ccb58a # v4.1.2
with:
path: ~/.elm
key: elm-${{ runner.os }}-${{ hashFiles('**/elm.json', 'elm-tooling.json') }}
Expand All @@ -65,15 +65,15 @@ jobs:

- name: Cache node_modules
id: cache-node_modules
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
uses: actions/cache@6849a6489940f00c2f30c0fb92c6274307ccb58a # v4.1.2
with:
path: node_modules
key: node_modules-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
restore-keys: |
node_modules-${{ runner.os }}-

- name: Cache turbo build setup
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
uses: actions/cache@6849a6489940f00c2f30c0fb92c6274307ccb58a # v4.1.2
with:
path: .turbo
key: ${{ runner.os }}-turbo-${{ github.sha }}
Expand Down