Break unparsable elm.json more #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assumed that too, but I just looked through it, it like is hasn't changed in over a year (beyond rubcop and sorbet fixes, and it used to shell out to elm if I understood correctly, though I didn't look too closely) |
jfmengels
force-pushed
the
break-unparsable-elmjson
branch
from
3e3a05e to
9814909
Compare
|
Well this passes after clearing the cache (#288 (comment)) 🤷♂️ |
|
Oh, I guess it passed b/c it's not considered part of cache key. I'll check. |
|
Nope, freak accident, I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #294
This will prevent dependabot from trying to update it (which I imagine it does because support for comments is improving?)