Limit the length of the RequestedBy field (#59)

jfrog · Feb 22, 2022 · 297d97d · 297d97d
1 parent bae5597
commit 297d97d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/build/golang.go b/build/golang.go
@@ -176,13 +176,13 @@ func populateZip(packageId, zipPath string) (zipDependency entities.Dependency,
 func populateRequestedByField(parentId string, parentRequestedBy [][]string, dependenciesMap map[string]entities.Dependency, dependenciesGraph map[string][]string) {
 	for _, childName := range dependenciesGraph[parentId] {
 		if childDep, ok := dependenciesMap[childName]; ok {
+			if childDep.NodeHasLoop() || len(childDep.RequestedBy) >= entities.RequestedByMaxLength {
+				continue
+			}
 			for _, requestedBy := range parentRequestedBy {
 				childRequestedBy := append([]string{parentId}, requestedBy...)
 				childDep.RequestedBy = append(childDep.RequestedBy, childRequestedBy)
 			}
-			if childDep.NodeHasLoop() {
-				continue
-			}
 			// Reassign map entry with new entry copy
 			dependenciesMap[childName] = childDep
 			// Run recursive call on child dependencies

diff --git a/entities/buildinfo.go b/entities/buildinfo.go
@@ -14,8 +14,9 @@ import (
 type ModuleType string
 
 const (
-	TimeFormat         = "2006-01-02T15:04:05.000-0700"
-	BuildInfoEnvPrefix = "buildInfo.env."
+	TimeFormat           = "2006-01-02T15:04:05.000-0700"
+	BuildInfoEnvPrefix   = "buildInfo.env."
+	RequestedByMaxLength = 10
 
 	// Build type
 	Build ModuleType = "build"