Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetPullRequest by ID #92

Merged
merged 20 commits into from
Jul 24, 2023
Merged

Add GetPullRequest by ID #92

merged 20 commits into from
Jul 24, 2023

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Jun 21, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used go fmt ./... for formatting the code before submitting the pull request.
  • This feature is included on all supported VCS providers - GitHub, Bitbucket cloud, Bitbucket server, and GitLab.

Implemented GetPullRequest function to get pull request info by ID.

@EyalDelarea EyalDelarea added the new feature Automatically generated release notes label Jun 21, 2023
@EyalDelarea EyalDelarea requested a review from yahavi June 21, 2023 12:01
@EyalDelarea EyalDelarea requested a review from omerzi June 27, 2023 14:58
omerzi
omerzi suggested changes Jun 28, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
vcsclient/logger.go Outdated Show resolved Hide resolved
vcsclient/vcsclient.go Outdated Show resolved Hide resolved
vcsclient/github.go Outdated Show resolved Hide resolved
@EyalDelarea EyalDelarea temporarily deployed to frogbot July 23, 2023 08:39 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

@EyalDelarea EyalDelarea merged commit a27a339 into jfrog:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerzi omerzi omerzi requested changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EyalDelarea @omerzi