Skip to content

Commit

Permalink
fix docker secret validation
Browse files Browse the repository at this point in the history
  • Loading branch information
attiasas committed Oct 29, 2024
1 parent 047b1ec commit bd8fd1a
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions commands/scan/scan.go
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ func (scanCmd *ScanCommand) RunAndRecordResults(cmdType utils.CommandType, recor
}

func (scanCmd *ScanCommand) RunScan(cmdType utils.CommandType) (cmdResults *results.SecurityCommandResults) {
xrayManager, cmdResults := initScanCmdResults(cmdType, scanCmd.serverDetails, scanCmd.analyticsMetricsService, scanCmd.bypassArchiveLimits)
xrayManager, cmdResults := initScanCmdResults(cmdType, scanCmd.serverDetails, scanCmd.analyticsMetricsService, scanCmd.bypassArchiveLimits, scanCmd.validateSecrets)
if cmdResults.GeneralError != nil {
return
}
Expand Down Expand Up @@ -309,7 +309,7 @@ func (scanCmd *ScanCommand) RunScan(cmdType utils.CommandType) (cmdResults *resu
return
}

func initScanCmdResults(cmdType utils.CommandType, serverDetails *config.ServerDetails, analyticsMetricsService *xsc.AnalyticsMetricsService, bypassArchiveLimits bool) (xrayManager *xrayClient.XrayServicesManager, cmdResults *results.SecurityCommandResults) {
func initScanCmdResults(cmdType utils.CommandType, serverDetails *config.ServerDetails, analyticsMetricsService *xsc.AnalyticsMetricsService, bypassArchiveLimits, validateSecrets bool) (xrayManager *xrayClient.XrayServicesManager, cmdResults *results.SecurityCommandResults) {
cmdResults = results.NewCommandResults(cmdType)
xrayManager, xrayVersion, err := xray.CreateXrayServiceManagerAndGetVersion(serverDetails)
if err != nil {
Expand All @@ -331,6 +331,9 @@ func initScanCmdResults(cmdType utils.CommandType, serverDetails *config.ServerD
return xrayManager, cmdResults.AddGeneralError(err)
} else {
cmdResults.SetEntitledForJas(entitledForJas)
if entitledForJas {
cmdResults.SetSecretValidation(jas.CheckForSecretValidation(xrayManager, xrayVersion, validateSecrets))
}
}
if analyticsMetricsService != nil {
cmdResults.SetMultiScanId(analyticsMetricsService.GetMsi())
Expand Down

0 comments on commit bd8fd1a

Please sign in to comment.