-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing context new status for CA #153
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out my comments. Also. add to integration tests the status. (validation + issue with the status)
Like in the validation methods: VerifySimpleJsonJasResults
cloud.google.com/go v0.38.0 // indirect | ||
github.com/Azure/azure-sdk-for-go v40.3.0+incompatible // indirect | ||
github.com/Azure/go-autorest/autorest v0.10.0 // indirect | ||
github.com/Azure/go-autorest/autorest/adal v0.8.2 // indirect | ||
github.com/Azure/go-autorest/autorest/azure/auth v0.4.2 // indirect | ||
github.com/Azure/go-autorest/autorest/azure/cli v0.3.1 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please only include the needed dependency for the test to reduce size and test times
…o missing-context
dev
branch.go vet ./...
.go fmt ./...
.Description:
New status in contextual analysis - missing context. If a CVE gets a missing context under contextual analysis this means that this CVE exists on binary but not on source code. (For example a scanner exists but is of type ELF, YAML, etc - not source code). This helps to distinguish between Not covered which means this CVE doesn't have a jfrog scanner at all to Missing context which means the CVE is covered but not on source code.
Since missing context doesn't mean Not applicable it has a higher priority. Also its not that its not Covered, just not covered in source code, which in conclusion we believe deserves a higher priority than Not covered as well.
Additional description:
Jfrog research team work on many CVEs using scanners they create. These scanners have a type, like JS, JAVASRC, YAML, etc..
When using jf audit we scan for src code, and therefore the scanners which can be run on the relevant project are only scanners of source code types which are being supported by the CLI (JAVASRC, JS, Python, NuGet soon and more) but not on scanners that are of type YAML, text, binary, elf, etc, however, these CVEs are supported on binary scanning on xray platform - So we want to distinguish between those CVEs that are not covered at all (no scanner) and those that are covered on xray platform but not on source code scanning (jf audit).
This CA status is only for jf audit.