Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing context new status for CA #153

Merged
merged 19 commits into from
Sep 17, 2024
Merged

Conversation

barv-jfrog
Copy link
Contributor

@barv-jfrog barv-jfrog commented Aug 21, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Description:
New status in contextual analysis - missing context. If a CVE gets a missing context under contextual analysis this means that this CVE exists on binary but not on source code. (For example a scanner exists but is of type ELF, YAML, etc - not source code). This helps to distinguish between Not covered which means this CVE doesn't have a jfrog scanner at all to Missing context which means the CVE is covered but not on source code.

Since missing context doesn't mean Not applicable it has a higher priority. Also its not that its not Covered, just not covered in source code, which in conclusion we believe deserves a higher priority than Not covered as well.

Additional description:
Jfrog research team work on many CVEs using scanners they create. These scanners have a type, like JS, JAVASRC, YAML, etc..
When using jf audit we scan for src code, and therefore the scanners which can be run on the relevant project are only scanners of source code types which are being supported by the CLI (JAVASRC, JS, Python, NuGet soon and more) but not on scanners that are of type YAML, text, binary, elf, etc, however, these CVEs are supported on binary scanning on xray platform - So we want to distinguish between those CVEs that are not covered at all (no scanner) and those that are covered on xray platform but not on source code scanning (jf audit).

This CA status is only for jf audit.

@hadarshjfrog
Copy link
Contributor

hadarshjfrog commented Aug 25, 2024

  1. Could you please add a bit more info the PR description. Maybe an example of when will a CVE will be found in a Binary but not in source? Is it a result that'll be relevant only for audit? or also for (docker) scan?

  2. Please add relevant results to SARIFs in: tests/testdata/other/applicability-scan.
    Also - can you add a project that will return such results when being scan?

Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out my comments. Also. add to integration tests the status. (validation + issue with the status)
Like in the validation methods: VerifySimpleJsonJasResults

utils/severityutils/severity.go Outdated Show resolved Hide resolved
utils/resultstable.go Outdated Show resolved Hide resolved
utils/jasutils/jasutils.go Show resolved Hide resolved
@attiasas attiasas added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Aug 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 26, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Sep 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 5, 2024
@attiasas attiasas self-requested a review September 5, 2024 09:15
Comment on lines 6 to 11
cloud.google.com/go v0.38.0 // indirect
github.com/Azure/azure-sdk-for-go v40.3.0+incompatible // indirect
github.com/Azure/go-autorest/autorest v0.10.0 // indirect
github.com/Azure/go-autorest/autorest/adal v0.8.2 // indirect
github.com/Azure/go-autorest/autorest/azure/auth v0.4.2 // indirect
github.com/Azure/go-autorest/autorest/azure/cli v0.3.1 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only include the needed dependency for the test to reduce size and test times

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Sep 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 16, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Sep 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 16, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit faa71b4 into jfrog:dev Sep 17, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants