New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new contextual scan statuses #36

Merged

attiasas merged 15 commits into jfrog:dev from orz25:support-new-contextual-scan-statuses

Apr 15, 2024

Contributor

orz25 commented Mar 12, 2024 •

edited

Loading

The pull request is targeting the dev branch.
The code has been validated to compile successfully by running go vet ./....
The code has been formatted properly using go fmt ./....
All static analysis checks passed.
All tests have passed. If this feature is not already covered by the tests, new tests have been added.
All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.


          Add support for new contextual scan statuses

95d9353

orz25 requested a review from attiasas

March 12, 2024 09:22

orz25 had a problem deploying to frogbot

March 12, 2024 09:22

— with

GitHub Actions Failure

orz25 commented

View reviewed changes

utils/resultstable.go Outdated Show resolved Hide resolved


          static code analysis fix

107fde0

orz25 had a problem deploying to frogbot

March 12, 2024 09:37

— with

GitHub Actions Failure

orz25 added the safe to test label

github-actions bot removed the safe to test label


          unit test fix

361a4c7

orz25 had a problem deploying to frogbot

March 12, 2024 10:18

— with

GitHub Actions Failure

orz25 added the safe to test label

github-actions bot removed the safe to test label

attiasas mentioned this pull request

Audit - Always run Applicability Scan if CVE discovered #37

Merged

6 tasks

attiasas reviewed

View reviewed changes

commands/audit/jas/applicability/applicabilitymanager_test.go Outdated Show resolved Hide resolved

attiasas reviewed

View reviewed changes

utils/analyzermanager.go Outdated Show resolved Hide resolved

attiasas reviewed

View reviewed changes

utils/resultstable.go Outdated Show resolved Hide resolved

attiasas reviewed

View reviewed changes

utils/resultstable.go Outdated Show resolved Hide resolved

attiasas reviewed

View reviewed changes

utils/resultstable.go Outdated Show resolved Hide resolved

attiasas reviewed

View reviewed changes

utils/resultstable.go Outdated Show resolved Hide resolved

attiasas reviewed

View reviewed changes

utils/resultstable.go Outdated Show resolved Hide resolved

attiasas reviewed

View reviewed changes

utils/resultstable_test.go Outdated Show resolved Hide resolved

attiasas reviewed

View reviewed changes

utils/resultstable_test.go Outdated Show resolved Hide resolved

attiasas reviewed

View reviewed changes

utils/resultwriter_test.go Outdated Show resolved Hide resolved

attiasas reviewed

View reviewed changes

utils/resultwriter_test.go Outdated Show resolved Hide resolved

attiasas reviewed

View reviewed changes

utils/test_sarifutils.go Show resolved Hide resolved

attiasas requested changes

View reviewed changes

Contributor

attiasas left a comment

At resultstable.go: Severities map, add the NotCovered (above NotApplicable) and change SeveritiesNumValues for all accordingly.
In addition make sure to handle it at the method: GetSeverity(severityTitle string, applicable ApplicabilityStatus) *TableSeverity

attiasas added the improvement label

attiasas marked this pull request as ready for review

March 13, 2024 15:17


          cr fixes

4e47a83

orz25 had a problem deploying to frogbot

March 14, 2024 13:27

— with

GitHub Actions Failure

orz25 added the safe to test label

github-actions bot removed the safe to test label

github-actions bot commented Mar 18, 2024

🐸 JFrog Frogbot

attiasas requested changes

View reviewed changes

Contributor

attiasas left a comment

Please Adjust the integration tests to also include all the statuses.

Make sure with the PM that the order of the statues are correct.

utils/test_sarifutils.go Outdated Show resolved Hide resolved

orz25 added 2 commits

March 18, 2024 16:03


          cr fixes

f911581


          add tests to new status

1d5e32c

orz25 had a problem deploying to frogbot

March 19, 2024 14:32

— with

GitHub Actions Failure

orz25 added 2 commits

March 20, 2024 12:52


          fix unit test

cc14d0d


          Merge remote-tracking branch 'upstream/dev' into support-new-contextu…

61d4b9f

…al-scan-statuses

orz25 had a problem deploying to frogbot

March 20, 2024 10:53

— with

GitHub Actions Failure

attiasas reviewed

View reviewed changes

tests/utils/test_validation.go Outdated Show resolved Hide resolved


          fix unit test

d2395f2

orz25 had a problem deploying to frogbot

March 25, 2024 10:28

— with

GitHub Actions Failure


          Merge remote-tracking branch 'upstream/dev' into support-new-contextu…

abcc6a7

…al-scan-statuses

orz25 had a problem deploying to frogbot

April 4, 2024 10:49

— with

GitHub Actions Failure


          Merge remote-tracking branch 'upstream/dev' into support-new-contextu…

f34050f

…al-scan-statuses

orz25 temporarily deployed to frogbot

April 15, 2024 12:02

— with

GitHub Actions Inactive

orz25 added the safe to test label

github-actions bot removed the safe to test label

attiasas approved these changes

View reviewed changes


          Merge remote-tracking branch 'upstream/dev' into support-new-contextu…

384ec5a

…al-scan-statuses-test

attiasas had a problem deploying to frogbot

April 15, 2024 16:08

— with

GitHub Actions Failure

attiasas added the safe to test label

github-actions bot removed the safe to test label


          fix tests

aba2afc

attiasas temporarily deployed to frogbot

April 15, 2024 16:59

— with

GitHub Actions Inactive

attiasas added the safe to test label

github-actions bot removed the safe to test label

github-actions bot commented Apr 15, 2024

🐸 JFrog Frogbot

attiasas merged commit c0ab022 into jfrog:dev

7 of 9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels