Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate distribution V1 commands definition to cli-artifactory #2853

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

Migrate distribution V1 commands definition to cli-artifactory #2853

wants to merge 18 commits into from

Conversation

bhanurp
Copy link
Collaborator

@bhanurp bhanurp commented Jan 31, 2025 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • Moved some common utils from cliutils to cli-core since cli-artifactory cant depend on jfrog-cli
  • Moved whole set of distribution v1 commands definition, list, usage, flags to cli-artifactory
  • With this PR distribution commands are fetched from cli-artifactory via artifactory embedded plugin app.

@bhanurp bhanurp marked this pull request as draft January 31, 2025 08:19
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Jan 31, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 31, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@bhanurp bhanurp marked this pull request as ready for review February 4, 2025 19:08
@bhanurp bhanurp changed the title WIP: Migrate distribution commands definition to cli-artifactory Migrate distribution V1 commands definition to cli-artifactory Feb 4, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

RobiNino
RobiNino approved these changes Feb 5, 2025
View reviewed changes
go.mod
@@ -189,9 +189,10 @@ require (
sigs.k8s.io/yaml v1.4.0 // indirect
)

replace github.com/jfrog/jfrog-cli-core/v2 => github.com/jfrog/jfrog-cli-core/v2 v2.31.1-0.20250130104846-27e495de291e
//replace github.com/jfrog/jfrog-cli-core/v2 => github.com/bhanurp/jfrog-cli-core/v2 v2.31.1-0.20250123053843-d005557d62d9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to update before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobiNino RobiNino RobiNino approved these changes

@EyalDelarea EyalDelarea Awaiting requested review from EyalDelarea

@itsmeleela itsmeleela Awaiting requested review from itsmeleela

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhanurp @RobiNino