Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Aarch64 support on source code scanning #432

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

noyshabtay
Copy link
Contributor

@noyshabtay noyshabtay commented Nov 1, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

  • Resolved a macOS issue where the Aarch64 architecture was incorrectly fetching the ARM-64 binary. Now, the correct ARM-64 architecture binary is retrieved.
  • In some functions dependencies changed to vulnerableDependencies for clarity.

…s incorrectly fetching the AMD-64 binary. Now, the correct ARM-64 architecture binary is retrieved.
@noyshabtay noyshabtay added bug Something isn't working safe to test Approve running integration tests on a pull request labels Nov 1, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@noyshabtay noyshabtay marked this pull request as ready for review November 1, 2023 14:13
@noyshabtay
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@noyshabtay noyshabtay requested a review from asafgabai November 1, 2023 14:17
@noyshabtay noyshabtay added the safe to test Approve running integration tests on a pull request label Nov 1, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 1, 2023
Copy link

github-actions bot commented Nov 5, 2023


This reverts commit d703fbc.
This reverts commit 03709cd.
@noyshabtay noyshabtay added the safe to test Approve running integration tests on a pull request label Nov 8, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 8, 2023
Copy link
Contributor

@asafgabai asafgabai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I suggest changing the title to something clearer and more specific.
Suggestion:
Fixed Aarch64 support on source code scanning

@noyshabtay noyshabtay changed the title Fixed Aarch64 issue on macOS Fixed Aarch64 support on source code scanning Nov 8, 2023
@noyshabtay noyshabtay merged commit c0822e1 into jfrog:master Nov 8, 2023
9 of 13 checks passed
@noyshabtay noyshabtay deleted the yarn1-hoisting branch November 8, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants