Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running executables with spaces in their paths in Windows #466

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Jan 24, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Update build-info version to 2.41.13

JAS scanners are not running on Windows machines where the user name has space in there name.
Updating build-info version to apply the fix for this issue: jfrog/build-info#777

@attiasas attiasas added the bug Something isn't working label Jan 24, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 24, 2024
@attiasas attiasas changed the title Update build-info version to 2.41.13 Fix running executables with spaces in their paths in Windows Jan 24, 2024
@@ -48,7 +48,7 @@ repositories {
}
}

def buildInfoVersion = '2.41.9'
def buildInfoVersion = '2.41.13'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the build-info version in ide-plugins-common too.

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 25, 2024
Copy link

🚨 Frogbot scanned this pull request and found the below:

📦 Vulnerable Dependencies

✍️ Summary

SEVERITY CONTEXTUAL ANALYSIS DIRECT DEPENDENCIES IMPACTED DEPENDENCY FIXED VERSIONS CVES

Low
Undetermined com.jfrog.ide:ide-plugins-common:2.3.6
com.jfrog.xray.client:xray-client-java:0.14.1
org.jfrog.buildinfo:build-info-client:2.41.13
org.jfrog.buildinfo:build-info-client 2.41.13 - -

Low
Undetermined com.jfrog.ide:ide-plugins-common:2.3.6 org.jfrog.buildinfo:build-info-extractor-go 2.41.13 - -

Low
Undetermined com.jfrog.ide:ide-plugins-common:2.3.6 org.jfrog.buildinfo:build-info-extractor-npm 2.41.13 - -

Low
Undetermined com.jfrog.ide:ide-plugins-common:2.3.6 org.jfrog.buildinfo:build-info-api 2.41.13 - -

Low
Undetermined com.jfrog.ide:ide-plugins-common:2.3.6
com.jfrog.xray.client:xray-client-java:0.14.1
org.jfrog.buildinfo:build-info-extractor:2.41.13
org.jfrog.buildinfo:build-info-extractor 2.41.13 - -
🔬 Research Details
[ XRAY-589059 ] org.jfrog.buildinfo:build-info-client 2.41.13

Description:
This package may be vulnerable to the MavenGate attack

[ XRAY-589059 ] org.jfrog.buildinfo:build-info-extractor-go 2.41.13

Description:
This package may be vulnerable to the MavenGate attack

[ XRAY-589059 ] org.jfrog.buildinfo:build-info-extractor-npm 2.41.13

Description:
This package may be vulnerable to the MavenGate attack

[ XRAY-589059 ] org.jfrog.buildinfo:build-info-api 2.41.13

Description:
This package may be vulnerable to the MavenGate attack

[ XRAY-589059 ] org.jfrog.buildinfo:build-info-extractor 2.41.13

Description:
This package may be vulnerable to the MavenGate attack


@attiasas attiasas merged commit 48b18c1 into jfrog:master Jan 25, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants