Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override a deprecated func to prevent unnecessary errors #476

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

eyalk007
Copy link
Contributor

@eyalk007 eyalk007 commented Aug 27, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

The ActionUpdateThread has a deprecated func called getActionUpdateThread.
We override it so we wont use the deprecated func that pops errors for all our users.
Is this case, the function should return EDT(Event Dispatch Thread) , as the current process affects the ui text.
This is not needed in other places in the code as it is already being override in all places.

@eyalk007 eyalk007 requested a review from eranturgeman August 27, 2024 12:34
@eyalk007 eyalk007 self-assigned this Aug 27, 2024
@eyalk007 eyalk007 added the bug Something isn't working label Aug 27, 2024
@eranturgeman eranturgeman changed the title added an override to the deprecated func so it wont pop and error for… Added an override to the deprecated func so it wont pop and error for… Aug 27, 2024
@eyalk007 eyalk007 changed the title Added an override to the deprecated func so it wont pop and error for… Added an override to deprecated func so it wont pop an error Aug 27, 2024
@eyalk007 eyalk007 linked an issue Aug 27, 2024 that may be closed by this pull request
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Aug 27, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 27, 2024
@eranturgeman eranturgeman changed the title Added an override to deprecated func so it wont pop an error Override a deprecated func to prevent unnecessary errors Aug 27, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@eyalk007 eyalk007 merged commit b2cc244 into jfrog:master Aug 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActionUpdateThread.OLD_EDT deprecated
2 participants