Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JFrog servers configurations cleanup #236

Merged
merged 7 commits into from
Dec 16, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Dec 15, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

PR Description:

This PR updates the JFrog server cleanup function to improve its behavior in certain scenarios:

  • When a custom server ID is set, the cleanup will only remove the configuration for that specific server.
  • If no custom server ID is specified, the cleanup will remove all configured servers.

This change addresses cases where multiple setup-jfrog-cli jobs are executed by the same agent, potentially causing server configurations to be deleted while they are still in use by other tasks. To avoid this issue, it is recommended to use a custom server ID.


@EyalDelarea EyalDelarea added the bug Something isn't working label Dec 15, 2024
@EyalDelarea EyalDelarea marked this pull request as ready for review December 15, 2024 17:28
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2024
@EyalDelarea EyalDelarea merged commit dff217c into jfrog:master Dec 16, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants