Add external dependencies fields to helm remote

[tenstad]

Closes #259

Tested with Artifactory 7.27.3

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[tenstad]

I have read the CLA Document and I hereby sign the CLA

[chb0github]

Has my approval! Thanks for the PR

[alexhung]

Should we be explicit about the default here with Default: "**",?

[tenstad]

There is no explicit default in remote docker repo: https://github.com/jfrog/terraform-provider-artifactory/blob/master/pkg/artifactory/resource_artifactory_remote_docker_repository.go#L35-L45

[chb0github]

Should we be explicit about the default here with Default: "**",?
I think so.

[tenstad]

I'm not sure how to add a default for a list, tried Default: []string{"**"},.

1 error occurred:
* resource artifactory_remote_helm_repository: external_dependencies_patterns: Default is not valid for lists or sets

hashicorp/terraform-plugin-sdk#142

[alexhung]

Thanks TF!

Artifactory schema documentation has no default value for externalDependenciesPatterns so is "**" the implicit default behavior from the API?

[alexhung]

[tenstad]

Thanks for the quick review @alexhung @chb0github!

Made a final adjustment, so that the example pattern is equal to the one in https://www.jfrog.com/confluence/display/JFROG/Kubernetes+Helm+Chart+Repositories

[alexhung]

With the exception on the default value for externalDependenciesPatterns, this PR is good to go for me.

Since TF doesn't allow default value to be set for TypeList or TypeSet, the only question I have is why ** is mentioned in the original description. This suggests either an implicit behavior of Artifactory (or the API), or a mistake in the description.

[alexhung]

Having said that, I just read the doc and it clearly states the ** default.

[tenstad]

I have been using https://github.com/tenstad/terraform-provider-artifactory/blob/tenstad/pkg/artifactory/resource_artifactory_remote_repository.go#L210-L215 for a while and checked my Artifactory insance. Found a lot of helm remotes with externalDependenciesPatterns: ["**"], where no value is configured in terraform.

When I now added a new helm remote with terraform (with the provider linked above), it got externalDependenciesPatterns: []. I think the default has been changed from ["**"] to [] in a semi-recent Artifactory release. However, when adding a remote helm repo in GUI, the default is still ["**"].

@alexhung should we update the description, and remove By default, this is set to ** which means that dependencies may be downloaded from any external source.?

Sorry for not discovering this earlier, I have been used to the ["**"] default, and as you say, the documentation also says so.

[alexhung]

@tenstad I can confirm the API defaults the externalDependenciesPatterns attribute to []. So let's update the attribute description (in separate PR) to mention this discrepancy between the UI and API.