Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some request properties are not being passed to hawk in Node16 #15

Merged
merged 1 commit into from
Mar 2, 2022
Merged

fix: some request properties are not being passed to hawk in Node16 #15

merged 1 commit into from
Mar 2, 2022

Commits on Feb 25, 2022

  1. fix: some request properties are not being passed to hawk in Node16 

    Due to nodejs/node#36550 (it was reverted in
Node 14 but it is back in Node 16). req.headers and other properties are
not own properties of requests so they are not cloned.

Node documentation (see discussion on nodejs/node#36550)
advices against clonning the req (or any stream object). This PR fixes that
without modifying the original request object by creating a new object which
prototype is the original request object instead of trying to clone
it.
    @dafortune
    dafortune committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    f0ab195 View commit details
    Browse the repository at this point in the history