Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for AMD, Require.js, Component #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

radiodario
Copy link

  • Added the standard wrapper for modules
  • Kept old noConflict etc.
  • Updated tests to use assert (i didn't know what assert.js you were loading)
  • Modify gruntfile not to lint assert.js

@jtenner
Copy link

jtenner commented Oct 13, 2014

@jgallen23 My body is ready for this pull request (and a submission to NPM would be godlike.)

@radiodario
Copy link
Author

lol

@cassiocardoso
Copy link

Is there any chance that this is approved?

@CtrlC-Root
Copy link
Contributor

@cassiocardoso I can merge it in although I'm not familiar with all of the components involved so if @radiodario would be willing to update this pull request to fix the conflicts I would be more than happy to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants