Check current route against hash instead of all routes #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes issue #30 |
When you add a new route reload is called. If any route matches the hash the route callback will be called every single time a new route is added. Rather than call reload we should check that the hash matches the current route and call or ignore it instead.
NicholasEymann
force-pushed
the
fix-routeloading
branch
from
936436f
to
08ac9cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you add a new route reload is called. If any route
matches the hash the route callback will be called every
single time a new route is added. Rather than call
reload we should check that the hash matches the
current route and call or ignore it instead.