add id attr directly in heading if possible #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of generating a useless <span id="..."> before the relevant <h?> tag, just add the id attr to the <h?> tag if it does not have one already. This way, the target of the link is exactly the <h?> tag, and the browser positions the focus exactly on it. Without this, there was a slight difference in offset between tags which had an id= attr an tags which didn't.
|
@moy Can you update this PR with the branch conflicts fixed? |
|
I didn't follow the development, but apparently the new version doesn't have the drawback I fixed with this PR, so I guess we can just close without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating a useless before the relevant
<h?> tag, just add the id attr to the <h?> tag if it does not have
one already.
This way, the target of the link is exactly the <h?> tag, and the
browser positions the focus exactly on it. Without this, there was a
slight difference in offset between tags which had an id= attr an
tags which didn't.