Fixes loading problems when Gem is built for Windows #62
Conversation
On Windows, the loading code in redcloth.rb assumed that one is loading it from a 'fat binary' gem. Using standard windows Ruby versions from 2.4 forward, the gem can be compiled by the user. This change first tries to require the library using the prefix (for fat gems). If that fails, it tries again to require without the prefix (for nuilt gems). Fixes jgarber#51 and jgarber#61.
Fix loading problems when Gem is built on Windows
|
Thanks @Silverfishnet! I have been wanting to get back to this gem to fix the JRuby issues... and this action of yours is motivation to do it now. |
| @@ -10,6 +10,11 @@ | |||
| conf = Object.const_get(defined?(RbConfig) ? :RbConfig : :Config)::CONFIG | |||
| prefix = conf['arch'] =~ /mswin|mingw/ ? "#{conf['MAJOR']}.#{conf['MINOR']}/" : '' | |||
| lib = "#{prefix}redcloth_scan" | |||
| begin | |||
There was a problem hiding this comment.
@mohits : there is another suggestion for this fix in #82 .
I am looking into the current PRs open and trying to merge them all.
Please let me know if you have a bit of time to review it for possible issues.
I commented in there as well that I find your code more safer, given I am still situating myself, and still moving slower.
There was a problem hiding this comment.
Hi @heliocola - I put this gem down in the list of things that I want to get back to and work on this year... just didn't expect it to fire up this early in the year. Let me try to put things back together and try to review the requirements again, and where I had stopped.
There was a problem hiding this comment.
Hi, I hope to be able to start looking at this in February again. I think I lost the VM on which I had the whole setup, and need to set it up to ensure that everything works correctly. For now, I think #51 and #61 can be closed with this.
I'm happy to collaborate, at least in reviewing the issues and doing triage, and helping to close the irrelevant ones.
|
Thank you! |
On Windows, the loading code in redcloth.rb assumed that one is loading it from a 'fat binary' gem. Using standard windows Ruby versions from 2.4 forward, the gem can be compiled by the user.
This change first tries to require the library using the prefix (for fat gems). If that fails, it tries again to require without the prefix (for built gems).
References: #51 and #61 for Windows users.