Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
I am not sure about #33.
NodeUi::UiPass
's ordering constraints seem nonsensical to me. I am probably not understanding it correctly. But I think that as long as we do your stuff beforeNode2d:: EndMainPassPostProcessing
, then this should also fix #33. I'm having trouble actually reproducing the issue though before or after this changeset though.Not a rendering expert, so this should be scrutinized.
Following the render graph setup in
custom_post_processing
, it seems that our render graph nodes are constrained to run afterNode2d::EndMainPass
, but otherwise free to run whenever. Might be before or after any of:Node2d::Bloom
Node2d::Tonemapping
Node2d::Fxaa
Node2d::Smaa
Node2d::Upscaling
Node2d::ContrastAdaptiveSharpening
Node2d::EndMainPassPostProcessing
I'm not totally sure this is exactly where the nodes belong, but it seems to fix the issue on my end.
I did the following experiments:
So it seems like this definitely needs to run before
Node2d::Upscaling
.