Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding German translation #152

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Adding German translation #152

merged 1 commit into from
Mar 26, 2023

Conversation

deining
Copy link
Contributor

@deining deining commented Mar 26, 2023

This PR adds the German translation for the theme messages. It also comes with some minor corrections for a few English message texts.

While translating, I realized a few duplicate message strings:

5_togglesidebar_wording:    Collapse/Uncollapse sidebar
sidebar_collapsible_title:  Collapse/Uncollapse sidebar
6_toggletoc_wording:    Collapse/Uncollapse toc
toc_collapsible_title:  Collapse/Uncollapse table of contents

Are these duplicates on purpose? Shouldn't that be consolidated?

@jgazeau
Copy link
Owner

jgazeau commented Mar 26, 2023

@deining , thanks for the PR.

Regarding 5_togglesidebar_wording and 6_toggletoc_wording they are actually for the sidebar and the table of content which are two different components (sidebar on the left and toc on the right) so they must be kept for now.

@jgazeau jgazeau merged commit ceb6d2c into jgazeau:main Mar 26, 2023
@jgazeau jgazeau added the documentation Improvements or additions to documentation label Mar 26, 2023
@deining deining deleted the i18n_de branch March 26, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants