-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run in web #73
base: master
Are you sure you want to change the base?
Run in web #73
Conversation
I've been trying for 30 minutes to test this in one of the web test environments, using various methods listed at https://code.visualstudio.com/api/extension-guides/web-extensions#web-extension-tests. But the good news is that this PR runs OK for me locally, and doesn't exhibit the same single-digit highlighting problem as I was reporting on #39. |
We can add it in a launch.json to make it easier to debug. |
Thanks. Sounds like I'd been doing the right thing. I'd tried a variety of browserTypes as well, given the following warning about Playwright which I couldn't get to go away. I consistently get variations of this error (when running from my local GH directory with the vsix file in):
I then remembered I'm running node v14.x (a requirement on the other project I contribute to), so I switched up to node 19.9.0, and updated everything, and then I get Chromium spinning up on localhost:3000 without errors, but it only gives a blank screen without any hint of VSCode other than its favicon. Passing different folders for test data doesn't help. |
try to open the dev tools (f12) and see if there are errors that make sense |
This is intended as an replacement PR for #39 which got messed up with conflicts.
@jgclark @alkatar21 can you look at it? I added a vsix as well.