Vimwiki reader #3705
Vimwiki reader #3705
Conversation
|
I think this may be ready to merge now. Let me know if there are any bugs or other problems. Edit: Sigh. Just found another bug. Will fix it soon. Edit 2: the bug is fixed. Ready to merge again. |
|
test/vimwiki-reader.html seems not to be used; can it be removed? |
|
Can you make sure that the code is wrapped to within 80 columns (as requested in CONTRIBUTING.md)? |
|
@jgm test/vimwiki-reader.html was the output of I have now enforced the 80 column rule. I also added support for diary links. I only added it now because it relies on configs in the vim plugin of vimwiki. Since there is a default config I'm using that, namely the diary links like |
src/Text/Pandoc/Readers/Vimwiki.hs
Outdated
| | s2 == "" = (s1, s2) | ||
| | head s2 == '#' = (s1, s2) | ||
| | otherwise = divByHash (s1 ++ [head s2]) (tail s2) | ||
|
|
There was a problem hiding this comment.
If the point of this function is to split a string on a prefix not containing # and a suffix starting with #, why not use the Prelude function break?
procLink s = procLink' x ++ y
where (x, y) = break (=='#') sThere was a problem hiding this comment.
I didn't know break - thanks for pointing it out.
src/Text/Pandoc/Readers/Vimwiki.hs
Outdated
| y <- many p2 | ||
| z <- p6 | ||
| return $ mconcat $ x:y++[z] | ||
| p2 :: PandocMonad m => VwParser m Blocks |
There was a problem hiding this comment.
You should put a blank line between the two function defs.
|
Thanks very much for this contribution. There may be further problems that appear, but I think this is in good shape to merge. |
|
Thanks very much for merging. I'll keep an eye on issues related to this reader. Also feel free to @ me whenever a problem appears. |
See #863.
This is a preliminary version.
Descriptions and comments about progress etc. are in the issue thread.