Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T.P.Format: add new function formatFromFilePaths [API Change] #8710

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

tarleb
Copy link
Collaborator

@tarleb tarleb commented Mar 20, 2023

The module Text.Pandoc.App.FormatHeuristics is removed.

@tarleb
Copy link
Collaborator Author

tarleb commented Mar 20, 2023

This is an alternative to #8693. Cc @mhwombat, who wrote that PR.

@tarleb
Copy link
Collaborator Author

tarleb commented Mar 20, 2023

I forgot to take the new function out of the Pandoc Monad; will fix that later.

@tarleb tarleb marked this pull request as ready for review March 20, 2023 21:31
The module `Text.Pandoc.App.FormatHeuristics` is removed.
Returns the likely format of a file based on the file name.
doc/lua-filters.md Outdated Show resolved Hide resolved
@jgm
Copy link
Owner

jgm commented Mar 21, 2023

This looks like a good improvement to me! I noted one typo.

@jgm jgm merged commit f1b55be into jgm:main Mar 21, 2023
@tarleb tarleb deleted the expose-format-heuristics branch March 21, 2023 06:20
@tarleb
Copy link
Collaborator Author

tarleb commented Mar 21, 2023

Thanks!
Large parts of lua-filters.md are now generated from the docs in the Haskell sources: the idea is that we can build an online help system without our other docs getting out of sync. That's why the pandoc.cli.repl note was in this PR: I had added the note to the Haskell sources, but forgotten to run make -B doc/lua-filters.md afterwards. The command updates that file with the docs from the sources. The repl note was added here when I ran it after adding the new from_path function.

There are still some API docs of lua-filters.md that are not generated from the sources, as the documentation system in HsLua is not powerful enough to capture the details adequately. I'm working on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants