Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getbinary return ByteString #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xandaros
Copy link

I also removed the unsafeInterleaveIO part because I don't know what it does. Seems to work without it.

If it does something crucial which I'm missing, you'll have to add it yourself, since I don't know how to do that with ByteStrings.

@jgoerzen
Copy link
Owner

jgoerzen commented Aug 1, 2017

I think the one feedback I would add is to add a new function that returns a ByteString, rather than remove the existing one, such that we don't introduce an API incompatibility.

@fizruk
Copy link
Contributor

fizruk commented Apr 24, 2019

I would rather just bump major version. ByteString is the way to go and String arguably should almost never be used 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants