Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teensy support #175

Closed
helloSeen opened this issue Aug 8, 2020 · 3 comments
Closed

Teensy support #175

helloSeen opened this issue Aug 8, 2020 · 3 comments
Labels
enhancement New feature or request resolved Issue was resolved (e.g. bug fixed, or feature implemented)

Comments

@helloSeen
Copy link

Building for Teensy 4.0
For Sx126X chip
IDE: vscode using platformIO plugin

When building I get the following error:

RadioLib\src\ISerial.cpp:35:30: error: 'class SoftwareSerial' has no member named 'stopListening'
   
return(_mod->ModuleSerial->stopListening());
@jgromes
Copy link
Owner

jgromes commented Aug 8, 2020

You should check out the warning it produces (assuming you have warnings enabled):

C:\Users\user\Documents\Arduino\libraries\RadioLib\src/RadioLib.h:60:4: warning: #warning "RadioLib might not be compatible with this Arduino board - check supported platforms at https://github.com/jgromes/RadioLib!" [-Wcpp]

That's because Teensy is not a supported platform. Trying to compile for Teensy 4.0 without the reference to SoftwareSerial::stopListening() will succeed, but I'm a bit conflicted about adding Teensy as a supported platform. As far as I can tell, Teensy cores can't be installed via arduino-cli, which I'm using to run CI testing via Travis, so that would mean no automated builds prior to new version release. Also, I don't have any Teensy boards, so I can't verify whether it will actually work with hardware.

@jgromes
Copy link
Owner

jgromes commented Aug 22, 2020

As a compromise, I removed the SoftwareSerial-only methods from ISerial class, so Teensy will compile now as an "Unknown" platform. However, for reasons stated in my previous comment, I am not going to add Teensy as an officially supported platform, at least not yet - inability to run CI is a dealbreaker here.

@jgromes jgromes closed this as completed Aug 22, 2020
@jgromes jgromes changed the title In ISerial.cpp, call to undefined member 'stopListening' for class SoftwareSerial Teensy support Aug 22, 2020
@jgromes jgromes added enhancement New feature or request wontfix This will not be worked on labels Aug 22, 2020
jgromes added a commit that referenced this issue Jun 12, 2022
@jgromes
Copy link
Owner

jgromes commented Jun 12, 2022

Even though this issue is way past stale, Teensy support for just added for arduino-cli, which means Teensy ca now be oficially supported in RadioLib.

@jgromes jgromes added resolved Issue was resolved (e.g. bug fixed, or feature implemented) and removed wontfix This will not be worked on labels Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resolved Issue was resolved (e.g. bug fixed, or feature implemented)
Projects
None yet
Development

No branches or pull requests

2 participants