New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SX1278 - setDataShaping writes into wrong register #186

Closed

eg321 opened this issue Oct 13, 2020 · 1 comment

Labels

bug resolved

eg321 commented Oct 13, 2020 •

edited

Loading

Describe the bug
Hi,

setDataShaping method for sx1278 writes into wrong register - SX127X_REG_OP_MODE, but it should use SX127X_REG_PA_RAMP (0x0A).
File to fix: \src\modules\SX127x\SX1278.cpp
Method: setDataShaping
Lines: https://github.com/jgromes/RadioLib/blob/master/src/modules/SX127x/SX1278.cpp#L359

Additional info:
It seems was broken here:
7dc7f4d

The text was updated successfully, but these errors were encountered:

jgromes added a commit that referenced this issue


          [SX127x] Fixed incorrect shaping register (#186)

e549039

Owner

jgromes commented Oct 13, 2020

You're right, that's indeed a bug that was introduced in that particular commit. Fixed, thanks for reporting!

jgromes closed this as completed

jgromes added bug resolved labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment