-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SX1262 Frequency Error #706
Comments
Can you post some details about your setup? The code, details about your platfrom etc. - pretty much everything requested by the issue template. Frequency error is experimental on SX126x, but seemed to be working for my use case (the SX126x_Receive/Receive_Interrupt examples). |
The hardware is two Heltec Wireless Stick V3 boards with ESP32S3 (not C3 as in earlier post) and SX1262. https://www.amazon.com/dp/B07S5XLP6Q?psc=1&ref=ppx_yo2ov_dt_b_product_details I am running your transmit and receive with interrupt examples on the two boards. The only changes were pins and LoRA config as follows: SX1262 radio = new Module(8, 14, 12, 13); I am using 0x12 for a sync word to be compatible with RadioHead which doesn't use a sync word but still transmits the default FSK 0x12 sync word. Everything so far works as expected except for frequency error. I like to use frequency error as a simple feed forward AFC. I run the exact same setup except for pin differences on a homebrew ESP32 and SX1276 board using the appropriate interrupt version examples which produce correct frequency error reports. It took me a while to get SX1276 and SX1262 interop because I didn't realize that your CRC on/off defaults were different. Once both were turned on, all is good. Larry |
Thanks for providing the configuration, with that I was able to replicate the issue. Turns out that there was a problem in the calulcation that I failed to see previously, ebcause I was testing with quite precise TCXXO modules. Using SX1278 with a bad crystal forced the issue. It should be fixed in the latest commit, thanks for reporting! PS:
As far as I can tell, defaults should be the same for both SX127x and SX126x. I tested that with |
Thanks for the update.
I am seeing the SX1276 default for CRC is off and for SX1262 default is
on. When I force both to on, interop is good. I don't have an SX1278 to
test.
When should I start looking for the next commit?
Larry
…On Wed, Mar 22, 2023 at 2:16 PM Jan Gromeš ***@***.***> wrote:
Thanks for providing the configuration, with that I was able to replicate
the issue. Turns out that there was a problem in the calulcation that I
failed to see previously, ebcause I was testing with quite precise TCXXO
modules. Using SX1278 with a bad crystal forced the issue. It should be
fixed in the latest commit, thanks for reporting!
PS:
It took me a while to get SX1276 and SX1262 interop because I didn't
realize that your CRC on/off defaults were different. Once both were turned
on, all is good.
As far as I can tell, defaults should be the same for both SX127x and
SX126x. I tested that with SX1278::begin() and SX1268::begin(), the two
different modules can communicate. Is that not the case for you?
—
Reply to this email directly, view it on GitHub
<#706 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRDHTW54VCZ2FGQ7YA54STW5NTZHANCNFSM6AAAAAAWBWIKGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Where exactly are you seeing this? Looking through the code, it actually seems that neither one explicitly sets CRC. EDIT: The commit fixing this issue was already pushed. |
Seeing is the wrong word. Using the defaults doesn't work. When I set the CRC to on for SX1276, it works. When CRC is set to on for the SX1262, it still works. |
@lvplummer FYI I explicitly enabled CRCs in the latest commits, so the defaults should match now. |
Thanks. Has the SX1262 frequency error correction been updated?
Larry
…On Thu, Mar 23, 2023 at 11:07 AM Jan Gromeš ***@***.***> wrote:
@lvplummer <https://github.com/lvplummer> FYI I explicitly enabled CRCs
in the latest commits, so the defaults should match now.
—
Reply to this email directly, view it on GitHub
<#706 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRDHTWCUVLLMLPV7HTTCKTW5SGPLANCNFSM6AAAAAAWBWIKGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yes, I pushed it yesterday. If you go through the conversation (in GitHub issues) you will see the referenced commits fixing it. |
I have it running and it works great.
Thanks,
Larry
…On Thu, Mar 23, 2023 at 1:10 PM Jan Gromeš ***@***.***> wrote:
Yes, I pushed it yesterday. If you go through the conversation (in GitHub
issues) you will see the referenced commits fixing it.
—
Reply to this email directly, view it on GitHub
<#706 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRDHTXMNNJBRSIO2JXTH2DW5SUZXANCNFSM6AAAAAAWBWIKGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I am using the great RadioLib with an ESP32C3 and SX1262. All works great except the reported frequency error. I get one good report and then wildly inaccurate results. Here is an example: -2241769.75. I am not sure if this is a bug or pilot error.
Larry
The text was updated successfully, but these errors were encountered: