Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA-01SC (LLCC68) module: wrong compare string leads to "failed, code -2" #707

Closed
TuxxuT opened this issue Mar 21, 2023 · 1 comment
Closed
Labels
bug Something isn't working resolved Issue was resolved (e.g. bug fixed, or feature implemented)

Comments

@TuxxuT
Copy link

TuxxuT commented Mar 21, 2023

Hi guys,

I use the library in version v5.7.0 with the LoRa Module RA-01SC (Semtech LLCC68).

// LLCC68 has the following connections:
// NSS pin: D1
// DIO1 pin: NC
// NRST pin: D0
// BUSY pin: D2
LLCC68 radio = new Module(D1, RADIOLIB_NC, D0, D2);

Later in code, the radio.begin() call always abort with "failed, code -2" because of the wrong compare string "SX126%d" in the SX126x::findChip method.

For the LLCC68 module it should be "LLCC68"...
If I am reading the data at address 0x0320 I get a reponse "LLCC68 V2H 2H02" from the Semtech LLCC68.

This behavior should be checked and changed if necessary. I think this is currently due to the inheritance from the SX126x class.

jgromes added a commit that referenced this issue Mar 21, 2023
@jgromes
Copy link
Owner

jgromes commented Mar 21, 2023

Thank you for reporting this, I was hoping I could get away with "SX126%d", but forgot LLCC68 is a thing. Fixed in the latest commit!

@jgromes jgromes closed this as completed Mar 21, 2023
@jgromes jgromes added bug Something isn't working resolved Issue was resolved (e.g. bug fixed, or feature implemented) labels Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved Issue was resolved (e.g. bug fixed, or feature implemented)
Projects
None yet
Development

No branches or pull requests

2 participants