Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 New CC1101 Functions #1038

Merged
merged 13 commits into from
Mar 28, 2024
Merged

3 New CC1101 Functions #1038

merged 13 commits into from
Mar 28, 2024

Conversation

Crsarmv7l
Copy link
Contributor

Not sure if you are interested in merging these, but figured I would offer.

There are 3 new functions:
getFrequency();
getBitRate();
CalcRxBandwidth();

Nothing spicy for the first two, they basically just return the variables for Freq and Bitrate. I can see them being useful to others though, if someone want to scan a freq range, and/or saving a signal you would need those two.

I really only put them in for the third one. CalcRxBandwidth() is an implementation of atlas0fd00m's calculatePktChanBW function in RfCat which works fairly well, based on the freq, baud and ppm. I tweaked it to work for this application and the CC1101 tolerances.

You can find his here: https://github.com/atlas0fd00m/rfcat/blob/07f99bbb9e2cdbde8658c9446fa0923d3a744d79/rflib/chipcon_nic.py#L973

Copy link
Owner

@jgromes jgromes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I left some comments, though nothing major. If those can be addressed, I think we can merge.

src/modules/CC1101/CC1101.cpp Outdated Show resolved Hide resolved
src/modules/CC1101/CC1101.cpp Outdated Show resolved Hide resolved
src/modules/CC1101/CC1101.h Outdated Show resolved Hide resolved
src/modules/CC1101/CC1101.h Outdated Show resolved Hide resolved
@jgromes
Copy link
Owner

jgromes commented Mar 28, 2024

@Crsarmv7l it looks like your branch has a conflict with the master due to change in keywords - could you please merge the latest master to your branch so that I can merge this? Thanks!

@Crsarmv7l
Copy link
Contributor Author

@Crsarmv7l it looks like your branch has a conflict with the master due to change in keywords - could you please merge the latest master to your branch so that I can merge this? Thanks!

You guys move fast. Manually merged the change. Looks like it worked

@jgromes jgromes merged commit 1fb5100 into jgromes:master Mar 28, 2024
29 checks passed
@jgromes
Copy link
Owner

jgromes commented Mar 28, 2024

All good now - merged, thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants