Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pin maps #1047

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Added pin maps #1047

merged 2 commits into from
Apr 1, 2024

Conversation

matthias-bs
Copy link
Contributor

No description provided.

@jgromes
Copy link
Owner

jgromes commented Apr 1, 2024

Thank you for the contribution! Have these pin maps been tested, or are they just from the documentation?

Also, this note #pragma message ("Connect DIO1 to GPIO33!") is a bit strange. I gather that in your setup, you conencted DIO1 to pin 33. However, DIO1 is not required for LoRaWAN, so it can be replaced with RADIOLIB_NC - and no hardware modification will be necessary.

@matthias-bs
Copy link
Contributor Author

Those pin maps are tried and tested with https://github.com/matthias-bs/BresserWeatherSensorTTN (based on Arduino LMIC - therefore DIO1 was needed. I thought RadioLib would need it, too.

@jgromes
Copy link
Owner

jgromes commented Apr 1, 2024

based on Arduino LMIC - therefore DIO1 was needed

I don't think so, RadioLib needs just one of the DIO pins for SX127x/6x to detect packet being received. We're not using CAD to detect when the LoRaWAN gateway is sending a message, just a simple delay and receive with timeout. So I think that note should be removed and RADIOLIB_NC should be used instead of GPIO33.

@matthias-bs
Copy link
Contributor Author

Modified as suggested.

@jgromes jgromes merged commit fbee747 into jgromes:master Apr 1, 2024
30 checks passed
@jgromes
Copy link
Owner

jgromes commented Apr 1, 2024

Looks good - merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants