Reconcile implicit double / float promotion in math functions. #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assed function value types. Also suppress incorrect unused variable warnings when variables are used in logging macros.
|
Thank you for the contribution! It seems a relatively minor change, and all looks good, so I merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR drops implicit conversion of floats and double literal values via the proposed changes. This resolves a bunch of warnings during compilation with all warnings enabled and prevents needless conversion of floats to doubles and back.
Lib continues to work as expected, though I'm utilizing this through a bespoke NonArduinoHAL in a Zephyr-based project.
PR also suppresses unused variable warning in situations where a var is used in print macros.