Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SX127x] fix DIO register mapping #1246

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

caveman99
Copy link
Contributor

this fixes #1244

@caveman99 caveman99 changed the title [SX1227x] fix DIO register mapping [SX127x] fix DIO register mapping Sep 30, 2024
@jgromes jgromes merged commit 5a9ff5a into jgromes:master Sep 30, 2024
30 checks passed
@jgromes
Copy link
Owner

jgromes commented Sep 30, 2024

Well that's a rather silly mistake isn't it ... fortunately these new IRQ methods are not being used internally by SX127x or LoRaWAN (yet), so I don't think we need to push this as another hotfix. Regardless, thank you for the fix!

@caveman99 caveman99 deleted the patch-1 branch September 30, 2024 15:19
@caveman99
Copy link
Contributor Author

unfortunately the setting of the registers is used in startReceive() https://github.com/jgromes/RadioLib/blob/5a9ff5a4912f87918390348c8caa54ea8a6afada/src/modules/SX127x/SX127x.cpp#L392C1-L401C26

After upgrading to 7.0.1 we were seeing RX not triggering the IRQ any more. It does not warrant a new release, we can just track the commit point for our builds, and i still have to check if this is really the fix for those problems. Test node is building as i write :-)

@jgromes
Copy link
Owner

jgromes commented Sep 30, 2024

I see - that is a significant issue then. I will push this as 7.0.2 then, otherwise it will be broken for everyone else using 7.0.1 and not tracking the latest commit.

@caveman99
Copy link
Contributor Author

I can confirm, operating two TLora 2.1-1.6 with SX1276 alongside each other, with the fix RX is fine, without it does not trigger the IRQ.

@jgromes
Copy link
Owner

jgromes commented Sep 30, 2024

@caveman99 FYI released as 7.0.2, hopefully that will be the last hotfix for a while ...

@caveman99
Copy link
Contributor Author

Thanks a lot for the quick response! :-) I hope so too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SX127x] IRQ mask handling uses the wrong DIO register
2 participants