Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable syncword generation & detection, add method to set preamble polarity #834

Merged
merged 8 commits into from
Sep 29, 2023

Conversation

baycom
Copy link
Contributor

@baycom baycom commented Sep 20, 2023

Ons patch allows the sync mechanism in the SX127X chips being disabled if setSyncWord is called with len=0 . Another patch adds a method for setting the preamble polarity. Both functions are being used in this project https://github.com/baycom/rps

Copy link
Owner

@jgromes jgromes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I left a few comments, though nothing major.

src/modules/SX127x/SX127x.cpp Outdated Show resolved Hide resolved
src/modules/SX127x/SX127x.cpp Outdated Show resolved Hide resolved
src/modules/SX127x/SX127x.h Outdated Show resolved Hide resolved
@jgromes jgromes merged commit d329c60 into jgromes:master Sep 29, 2023
29 checks passed
@jgromes
Copy link
Owner

jgromes commented Sep 29, 2023

@baycom to not block this PR any longer, I did the changes myself.

Thank you so much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants