Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.tags.has-addons.is-right introduces margins at wrong place #2091

Closed
bertBruynooghe opened this issue Sep 6, 2018 · 2 comments · Fixed by tghelere/valorize-vidas#6 · May be fixed by devopsred/gaia#6, anikets43/angular-ngrx-socket-frontend#4 or jwlh/WDI_GROUP_PROJECT#2

Comments

@bertBruynooghe
Copy link

This is about Bulma.

Overview of the problem

This is about the Bulma CSS framework

I'm using Bulma version [0.7.1]

Description

When using `class="tags has-addons is-right", a margin is introduced between the tag parts.

Steps to Reproduce

<div class="tags has-addons is-right">
    <span class="tag">Package</span>
    <span class="tag is-primary">Bulma</span>
</div>

Expected behavior

'Package' and 'Bulma' should be nicely glued together, aligned to the right.

Actual behavior

There is a gap between 'Package' and 'Bulma'

@msangui
Copy link

msangui commented Oct 1, 2018

I think the right fix is to add a quick "exception" in elements/tag.sass:

 &.is-centered, &.is-right
    .tag
      margin-left: 0
      margin-right: 0

in line 28 right after .has-addons definition

@bertBruynooghe
Copy link
Author

FYI: I patched locally using:

.tags.is-right.has-addons .tag:not(:first-child) {
    margin-left: 0;
}

gvdp pushed a commit to gvdp/bulma that referenced this issue Oct 27, 2018
gvdp pushed a commit to gvdp/bulma that referenced this issue Oct 27, 2018
gvdp pushed a commit to gvdp/bulma that referenced this issue Oct 28, 2018
gvdp pushed a commit to gvdp/bulma that referenced this issue Oct 29, 2018
gvdp pushed a commit to gvdp/bulma that referenced this issue Oct 29, 2018
jgthms pushed a commit that referenced this issue Oct 31, 2018
…2188)

* #2091 remove css rule which causes has-addons to not work correctly

* #2091 remove css rule which causes has-addons to not work correctly

* #2091 Don't include compiled css

* #2091 Don't include compiled css
@jgthms jgthms closed this as completed in 000b3ef Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment