Fix Webpack build by importing variables in mixins file #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That file is deprecated. It should be either the initial or derived one. |
|
My branch was derived from your master branch today. So I think I don't understand what you mean by it is deprecated. I tried to build something with Webpack and use the current version of Bulma for it (0.5.3) and I got the error mentioned in #708. I fixed it with this modification and it works well now. |
|
confirmed. adding that @import satisfies webpack and everything works well again. |
|
It should import |
jgthms
pushed a commit
that referenced
this pull request
Oct 9, 2017
* Fix Webpack build by importing variables in mixins file * Import initial-variables instead of variables.sass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #708
Original commit: kiwicopple/bulma@11a993e
(I couldn't find kiwicopple's repo in the select field when creating pull request so I created a fork myself)