Make centered buttons have equal margin #2381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix.
Proposed solution
Issue
When you have long buttons within .buttons.is-centered and a button moves to a lower line the alignment of each button is off.
Same issue with .buttons.is-right
Solution
Add equal margin to both sides of the button.
Tradeoffs
We are using button margin value of 0.5rem (0.25rem each side for .is-centered) that value could change so it might be beneficial to use a variable here instead.
Testing Done
I have some js-fiddles with my tests:
shrink the screen to see the broken buttons under
Before:
After: