Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove height: auto from media elements #15

Merged
merged 3 commits into from
Jan 19, 2019

Conversation

rch850
Copy link
Contributor

@rch850 rch850 commented Aug 15, 2018

This is a backport from bulma commit b8a7ab2a.

I am a user of bulma and found that <audio> element is broken in Chrome because the height is auto.

This PR will fix the issue of bulma again.

This is a backport from bulma commit b8a7ab2a.
@jgthms
Copy link
Owner

jgthms commented Oct 28, 2018

I think the solution is to remove audio only then.

@rch850
Copy link
Contributor Author

rch850 commented Nov 4, 2018

Thank. I have fixed it.

@jgthms jgthms merged commit 0795881 into jgthms:master Jan 19, 2019
@rch850 rch850 deleted the fix-media-height branch January 21, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"height: auto" overrides default height for audio elements, setting it to zero
2 participants