Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address issue #17, set default background for input and textarea #19

Closed
wants to merge 1 commit into from
Closed

Conversation

sammdu
Copy link

@sammdu sammdu commented Mar 5, 2019

Addresses Isssue #17

Set default background of <textarea> and <input> to white and color to black;
Fix Firefox issue with dark GTK themes where input elements turn dark without consideration of content.

Thank you!

@Pizzacus
Copy link

No, wait, the issue also mentioned putting that on :root too

@sammdu
Copy link
Author

sammdu commented Mar 10, 2019

@Pizzacus Yes sorry I forgot to mention; I tried that on Firefox, and for some reason the favicons (you saw it right) as well as some other non-web elements in the browser starts getting affected.
I use Firefox on Linux with a dark GTK theme.

p.s. I now have the above changes of input and textarea in my userContent.css of my firefox profile, and I haven't seen major problems since

@Pizzacus
Copy link

Wait, the favicons? Do you have a screenshot of it? That sounds like quite a peculiar case...

@sammdu
Copy link
Author

sammdu commented Mar 10, 2019

@Pizzacus refer back to issue #17
I have added a screenshot

@sammdu
Copy link
Author

sammdu commented Apr 7, 2019

@jgthms Discussion on issue #17 have been mostly concluded. The issue of Firefox mal-rendering pages under dark GTK themes have been addressed by the following rule:

input,
textarea {
  background-color: #fff;
  color: #000;
}

Please consider merging the pull request at your convenience.
Thanks!

@sammdu sammdu closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants