Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /kick command and remove botan support #38

Merged
merged 27 commits into from
Dec 7, 2017
Merged

Conversation

isjerryxiao
Copy link
Contributor

No description provided.

@jh0ker
Copy link
Owner

jh0ker commented Sep 19, 2017

Looks nice. I was wondering, perhaps it would be helpful if you could kick a player by replying to one of the messages of the player you want to kick. The bot should be able to see the messages that are sent via @thebot, even with privacy mode enabled, so you could get the ID from that. What do you think?

@isjerryxiao
Copy link
Contributor Author

isjerryxiao commented Sep 19, 2017

You are right. It's much more convenient to kick a specific person by replying.

@jh0ker
Copy link
Owner

jh0ker commented Oct 21, 2017

I think I want to merge #44 first, you will probably have to do a manual merge after that. Sorry about that :/

@isjerryxiao
Copy link
Contributor Author

No problem, but I'm currently a little busy, and the new function is not very stable now.

@jh0ker
Copy link
Owner

jh0ker commented Oct 21, 2017

@jerry981028 Alright 👍

@isjerryxiao
Copy link
Contributor Author

#44 is merged. I'll manually merge these things in a couple of days.

@isjerryxiao
Copy link
Contributor Author

Ok, it's able to merge.

@isjerryxiao
Copy link
Contributor Author

isjerryxiao commented Dec 6, 2017

Since botan is deleted in this commit, is it still necessary to keep it in the bot?

@jh0ker
Copy link
Owner

jh0ker commented Dec 6, 2017

I think we can drop botan support completely.

@isjerryxiao
Copy link
Contributor Author

Ok, I'll delete those codes.

@isjerryxiao
Copy link
Contributor Author

isjerryxiao commented Dec 6, 2017

Deleted.
It works normally without issues in a short test.

@isjerryxiao isjerryxiao changed the title Add /kick command for admins. Add /kick command and remove botan support Dec 6, 2017
@jh0ker
Copy link
Owner

jh0ker commented Dec 7, 2017

Nice, thanks for the config rework as well 👍 You think this is good to merge? Looks good to me

@isjerryxiao
Copy link
Contributor Author

Tested. It's well-prepared to merge.

@jh0ker jh0ker merged commit 1c713de into jh0ker:master Dec 7, 2017
@jh0ker
Copy link
Owner

jh0ker commented Dec 7, 2017

Thanks again for your contribution!

@isjerryxiao
Copy link
Contributor Author

My pleasure.

@jh0ker
Copy link
Owner

jh0ker commented Dec 7, 2017

Changes are live 🚀

@isjerryxiao
Copy link
Contributor Author

isjerryxiao commented Dec 7, 2017

Maybe the command list of @unobot should be updated.
Here's mine

join - Join the current game  
start - Start the game  
leave - Leave the game you're in  
close - Close the game lobby  
open - Open the game lobby  
kill - Terminate the game  
kick - Kick players out of the game  
enable_translations - Enable multi-translations  
disable_translations - Disable multi-translations  
skip - Skip the current player  
notify_me - Get a message when there's a new game in this group  
help - How to use this bot?  
settings - Language and other settings  
stats - Show statistics  
source - See source information  
news - All news about this bot  
modes - Explanation of game modes```

@jh0ker
Copy link
Owner

jh0ker commented Dec 7, 2017

Thanks, I updated the command list. I only moved the modes command under help where I had it before

@isjerryxiao
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants