🪟 🔧 Add Segment track event to suggested destinations experiment (ai…

…rbytehq#17328) * Add segment track event to suggested destinations experiment Closes airbytehq#17257 * Fix spec
jhammarstedt · Oct 31, 2022 · 2e5734a · 2e5734a
1 parent 9955f31
commit 2e5734a
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 5 deletions.
diff --git a/...bapp/src/pages/DestinationPage/pages/CreateDestinationPage/components/DestinationForm.tsx b/...bapp/src/pages/DestinationPage/pages/CreateDestinationPage/components/DestinationForm.tsx
@@ -52,7 +52,10 @@ export const DestinationForm: React.FC<DestinationFormProps> = ({
     isLoading,
   } = useGetDestinationDefinitionSpecificationAsync(destinationDefinitionId);
 
-  const onDropDownSelect = (destinationDefinitionId: string) => {
+  const onDropDownSelect = (
+    destinationDefinitionId: string,
+    trackParams?: { actionDescription: string; connector_destination_suggested: boolean }
+  ) => {
     setDestinationDefinitionId(destinationDefinitionId);
 
     const connector = destinationDefinitions.find((item) => item.destinationDefinitionId === destinationDefinitionId);
@@ -65,6 +68,7 @@ export const DestinationForm: React.FC<DestinationFormProps> = ({
       actionDescription: "Destination connector type selected",
       connector_destination: connector?.name,
       connector_destination_definition_id: destinationDefinitionId,
+      ...trackParams,
     });
   };
 

diff --git a/airbyte-webapp/src/views/Connector/ServiceForm/ServiceForm.tsx b/airbyte-webapp/src/views/Connector/ServiceForm/ServiceForm.tsx
@@ -121,7 +121,10 @@ export interface ServiceFormProps {
   formId?: string;
   availableServices: ConnectorDefinition[];
   selectedConnectorDefinitionSpecification?: ConnectorDefinitionSpecification;
-  onServiceSelect?: (id: string) => void;
+  onServiceSelect?: (
+    id: string,
+    trackParams?: { actionDescription: string; connector_destination_suggested: boolean }
+  ) => void;
   onSubmit: (values: ServiceFormValues) => void;
   isLoading?: boolean;
   isEditMode?: boolean;

diff --git a/...tor/ServiceForm/components/FrequentlyUsedDestinations/FrequentlyUsedDestinations.test.tsx b/...tor/ServiceForm/components/FrequentlyUsedDestinations/FrequentlyUsedDestinations.test.tsx
@@ -38,7 +38,10 @@ describe("<FrequentlyUsedDestinations />", () => {
 
     await waitFor(() => {
       expect(handler).toHaveBeenCalledTimes(1);
-      expect(handler).toHaveBeenCalledWith("2");
+      expect(handler).toHaveBeenCalledWith("2", {
+        actionDescription: "Suggested destination connector type selected",
+        connector_destination_suggested: true,
+      });
     });
   });
 });
diff --git a/...onnector/ServiceForm/components/FrequentlyUsedDestinations/FrequentlyUsedDestinations.tsx b/...onnector/ServiceForm/components/FrequentlyUsedDestinations/FrequentlyUsedDestinations.tsx
@@ -12,7 +12,10 @@ import styles from "./FrequentlyUsedDestinations.module.scss";
 export interface FrequentlyUsedDestinationsProps {
   propertyPath: string;
   destinations: DestinationConnectorCard[];
-  onDestinationSelect?: (id: string) => void;
+  onDestinationSelect?: (
+    id: string,
+    trackParams?: { actionDescription: string; connector_destination_suggested: boolean }
+  ) => void;
   isLoading?: boolean;
 }
 
@@ -30,7 +33,10 @@ export const FrequentlyUsedDestinations: React.FC<FrequentlyUsedDestinationsProp
   }
   const onSlideClick = (id: string) => {
     setValue(id);
-    onDestinationSelect?.(id);
+    onDestinationSelect?.(id, {
+      actionDescription: "Suggested destination connector type selected",
+      connector_destination_suggested: true,
+    });
   };
   return (
     <div className={styles.container}>