issue 95 fix undiscard returns false unless discarded?

jhawthorn · Aug 17, 2023 · fee0bc0 · fee0bc0
1 parent 534739e
commit fee0bc0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/discard/model.rb b/lib/discard/model.rb
@@ -138,7 +138,7 @@ def discard!
     #
     # @return [Boolean] true if successful, otherwise false
     def undiscard
-      return unless discarded?
+      return false unless discarded?
       run_callbacks(:undiscard) do
         update_attribute(self.class.discard_column, nil)
       end

diff --git a/spec/discard/model_spec.rb b/spec/discard/model_spec.rb
@@ -85,6 +85,10 @@
             post.undiscard
           }.not_to change { post.reload.discarded_at }
         end
+
+        it "returns false" do
+          expect(post.undiscard).to be false
+        end
       end
 
       describe '#undiscard!' do
@@ -139,6 +143,10 @@
             post.discard
           }.not_to change { post.reload.discarded_at }
         end
+
+        it "returns false" do
+          expect(post.discard).to be false
+        end
       end
 
       describe '#discard!' do