def undiscard doesn't follow return false pattern

[chiperific]

Describe the bug
https://github.com/jhawthorn/discard/blob/master/lib/discard/model.rb#L141

def undiscard seems to violate its expected return value constraints.

    # Discard the record in the database
    #
    # @return [Boolean] true if successful, otherwise false
    def discard
      return false if discarded?
      run_callbacks(:discard) do
        update_attribute(self.class.discard_column, Time.current)
      end
    end

    ...

    # Undiscard the record in the database
    #
    # @return [Boolean] true if successful, otherwise false
    def undiscard
      return unless discarded? # <-------- returns nil
      run_callbacks(:undiscard) do
        update_attribute(self.class.discard_column, nil)
      end
    end

Shouldn't this be return false unless discarded??

Current behavior

> record = SomeModel.first
> record.discarded?
=> false
> record.undiscard # should return false
nil

Expected behavior

> record = SomeModel.first
> record.discarded?
=> false
> record.undiscard # should return false
false

Additional context

• Ruby 3.1.4
• Rails 7.0.7

[jarednorman]

Good find! I would accept a change that fixed this.