Use PeriodicThread for sampling #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to cancel the periodic thread before waiting for the sampling interval.
jhawthorn
force-pushed
the
periodic_thread
branch
from
f51395e to
73b3a2a
Compare
jhawthorn
force-pushed
the
periodic_thread
branch
from
73b3a2a to
f8b7793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use the same "PeriodicThread" implementation that came from the recent memory profiling for the sampling timer as well.
This allows us to cancel the thread more quickly (previously we had to wait for the timer to expire to stop the sampling thread) and I want to build the ability to "pause" profiling on top of this, which I then want to use to fix the issues we have when forking.