Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up DrupalSubContextInterface. #140

Merged
merged 2 commits into from
Feb 14, 2015

Conversation

pfrenssen
Copy link
Collaborator

DrupalSubContextInterface could use a little love:

  • The docblock for the constructor is not correct, it uses the wrong parameter type for $context.
  • it states that the constructor returns a string but a constructor cannot return any value since it returns the object itself.
  • We can also add some documentation to help people understand its purpose.

@pfrenssen
Copy link
Collaborator Author

I also renamed the $context variable to $drupal. This better conveys what it contains, and this variable name is also used in the FooFoo example implementation .

@pfrenssen pfrenssen force-pushed the DrupalSubContextInterface branch from a5f56f6 to fe3c701 Compare February 13, 2015 14:53
jhedstrom added a commit that referenced this pull request Feb 14, 2015
@jhedstrom jhedstrom merged commit 3601f19 into jhedstrom:master Feb 14, 2015
jhedstrom added a commit that referenced this pull request Feb 14, 2015
Clean up DrupalSubContextInterface.

Signed-off-by: Jonathan Hedstrom <jhedstrom@gmail.com>
@pfrenssen pfrenssen deleted the DrupalSubContextInterface branch June 18, 2015 17:22
xurizaemon pushed a commit to xurizaemon/drupalextension that referenced this pull request Nov 30, 2022
…ndards

Fixes for updated coding standards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants