Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"I am viewing my :type (content )with the title :title" generates notice on anonymous user #168

Merged
merged 1 commit into from
May 6, 2015

Conversation

lpeabody
Copy link

@lpeabody lpeabody commented May 6, 2015

Changes

  • Replaced !$this->user->uidwith !isset($this->user->uid) which represses the notice and you will instead get the intended exception message.

…enerate a notice:

Notice: Trying to get property of non-object in vendor/drupal/drupal-extension/src/Drupal/DrupalExtension/Context/DrupalContext.php line 237

Wrapping with isset takes care of the notice, and you instead get the intended Exception message.
jhedstrom added a commit that referenced this pull request May 6, 2015
"I am viewing my :type (content )with the title :title" generates notice on anonymous user
@jhedstrom jhedstrom merged commit cba0911 into jhedstrom:master May 6, 2015
@jhedstrom
Copy link
Owner

Thanks!

jhedstrom added a commit that referenced this pull request May 6, 2015
"I am viewing my :type (content )with the title :title" generates notice on anonymous user

Signed-off-by: Jonathan Hedstrom <jhedstrom@gmail.com>
xurizaemon pushed a commit to xurizaemon/drupalextension that referenced this pull request Nov 30, 2022
- Allows usage of the field value label instead of the key.
- Fixes jhedstrom#168.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants