Provide a step to check that a button is not in a region. #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice addition! Could you add a test for this? |
idimopoulos
force-pushed
the
assert_not_region_button
branch
from
1cb163f to
2002f6e
Compare
|
This should do the trick, but the test looks for the "content" region on the homepage, but this page has no content. Could you maybe change it to instead look into the "right header"? |
|
Great, thanks! We have a positive and negative step definition for most things, but the negative one was missing for buttons, and this is now fixed 👍 |
pfrenssen
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a step in
MarkupContextto assert that a button exists within a region but not one to assert that one does not exist. Here is a small patch.