Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mp4.R #25

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Update mp4.R #25

merged 1 commit into from
Jun 21, 2021

Conversation

EvaMaeRey
Copy link
Contributor

numeric pointer to the slides that should be included?

numeric pointer to the slides that should be included.
@jhelvy
Copy link
Owner

jhelvy commented Jun 21, 2021

Ah, good idea. I do this with build_png() but I didn't include it for mp4, gif, or pptx, which all build from the pdf. I'll pull in this request then I'll make some quick modifications to it so that it's properly documented and so that the argument names match (I use slides for build_png(), so I'll use that instead of which.

@jhelvy jhelvy merged commit 55eba22 into jhelvy:master Jun 21, 2021
@jhelvy
Copy link
Owner

jhelvy commented Jun 21, 2021

Okay, I think I've got everything harmonized now with the last commit. Could you try build_mp4() with the latest version to see if the slides argument works to only build the vector of specified slide numbers? Should also work for build_gif() and build_pptx().

@EvaMaeRey
Copy link
Contributor Author

Great! Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants