Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cli fancy formatting again for build messages #32

Merged
merged 4 commits into from
Jul 16, 2021

Conversation

gadenbuie
Copy link
Collaborator

This resolves the issue previously seen in #19 where output_file wasn't found and that was caused by a confused cli_process_start() when called within a function but attached to a different environment (where output_file didn't exist).

This fixes that particular issue by building the message first using cli::format_inline() before calling cli_process_start().

While in there I also updated the printing method. I reversed the phrasing to Building input into output since I think this reads in chains better (the output of one line becomes the input of the next).

I also updated the messages to provide a little more context about where the files are being written by printing the paths relative to the working directory.

image

@jhelvy
Copy link
Owner

jhelvy commented Jul 16, 2021

Really nice job with this, and I like the change to "into" in the descriptions. It's much more clear about what is being built and where it is going. This will also be much nicer once the changes in #30 are implemented as you'll be able to see where something is being built even if the user didn't specify the output directory in output_file.

@jhelvy jhelvy merged commit 9cabf8a into jhelvy:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants