Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-devtools-core from ^4.10.1 to ~4.10.3 #587

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Apr 28, 2021

Updates react-devtools-core dependency to version ~4.10.3 (created from facebook/react#21344) as outlined in facebook/react#21326.


The short term plan (this PR) is:

  1. Branch and make a patch release of DevTools 4.10 that adds a protocol check to the frontend (to detect any newer backends).
  2. Upgrade Flipper (and recommend upgrade for the OSS React Native Debugger as well) to this new frontend.
  3. Wait a week or so for rollout and then upgrade React Native to the 4.13 backend.

The long term plan going forward (to be released as 4.13)):

  1. Add an explicit version to the protocol used by the DevTools "backend" and "frontend" components to talk to each other.
  2. Check this protocol during initialization to ensure it matches.
  3. Show upgrade/downgrade instructions if there's a mismatch (or if the check times out without a response– indicating an older backend).
  4. Release this as 4.13.

@bvaughn bvaughn force-pushed the upgrade-react-devtools-core branch from d5ec6c3 to 00c12b0 Compare April 28, 2021 03:55
@jhen0409 jhen0409 merged commit 805dd44 into jhen0409:master Apr 29, 2021
@jhen0409
Copy link
Owner

Thanks!

@bvaughn
Copy link
Contributor Author

bvaughn commented Apr 29, 2021

Thank you!

@bvaughn bvaughn deleted the upgrade-react-devtools-core branch April 29, 2021 14:00
@bvaughn bvaughn changed the title Update react-devtools-core from ^4.10.1 to ~4.10.2 Update react-devtools-core from ^4.10.1 to ~4.10.3 Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants