Skip to content

Commit

Permalink
Fix a memory corruption issue in H5S__point_project_simple (HDFGroup#…
Browse files Browse the repository at this point in the history
  • Loading branch information
jhendersonHDF committed Mar 24, 2023
1 parent 3ce739c commit 7383dbc
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
14 changes: 14 additions & 0 deletions release_docs/RELEASE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,20 @@ Bug Fixes since HDF5-1.12.1 release
===================================
Library
-------
- Fixed a memory corruption issue that can occur when reading
from a dataset using a hyperslab selection in the file
dataspace and a point selection in the memory dataspace

When reading from a dataset using a hyperslab selection in
the dataset's file dataspace and a point selection in the
dataset's memory dataspace where the file dataspace's "rank"
is greater than the memory dataspace's "rank", memory corruption
could occur due to an incorrect number of selection points
being copied when projecting the point selection onto the
hyperslab selection's dataspace.

(JTH - 2023/03/23)

- Seg fault on file close

h5debug fails at file close with core dump on a file that has an
Expand Down
2 changes: 1 addition & 1 deletion src/H5Spoint.c
Original file line number Diff line number Diff line change
Expand Up @@ -2316,7 +2316,7 @@ H5S__point_project_simple(const H5S_t *base_space, H5S_t *new_space, hsize_t *of
/* Copy over the point's coordinates */
HDmemset(new_node->pnt, 0, sizeof(hsize_t) * rank_diff);
H5MM_memcpy(&new_node->pnt[rank_diff], base_node->pnt,
(new_space->extent.rank * sizeof(hsize_t)));
(base_space->extent.rank * sizeof(hsize_t)));

/* Keep the order the same when copying */
if (NULL == prev_node)
Expand Down

0 comments on commit 7383dbc

Please sign in to comment.